After some head scratching I finally found the reason why my scp isn’t working anymore. It’s my prompt recoloring and indentation! Put this in the begining of your .bashrc to make sure bash isn’t confusing scp when not meant for interactive use:
[ -z "$PS1" ] && return